New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 fixes - fix various TestBase issues #6228

Merged
merged 6 commits into from Jul 25, 2018

Conversation

Projects
None yet
2 participants
@Eric-Arellano
Copy link
Contributor

Eric-Arellano commented Jul 24, 2018

Running any test suite that extends TestBase will fail due to ~5 different problems.

To reproduce, add compatibility='CPython>=3.5', to pants_test/util/BUILD entry of meta, then run

./pants test tests/python/pants_test/util:meta

@stuhood stuhood merged commit 6c90f8e into pantsbuild:master Jul 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:py3-fixes_various-test-base-issues branch Jul 25, 2018

stuhood added a commit that referenced this pull request Jul 26, 2018

Python 3 fixes - fix dirutil, fileutil, and xml_parser tests (#6229)
### Problem
Dirutil tests failing due to unicode vs bytes. 

`dirutil.py` itself is fine. I decided `safe_file_dump()` and `read_file()` should still work with bytes, not unicode.

### Related PRs
To get completely green on Py3, requires #6226 and #6228. This can be merged before them both, though, as it shouldn't break Py2 and we aren't running Py3 yet.

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Python 3 fixes - fix various TestBase issues (pantsbuild#6228)
Running any test suite that extends `TestBase` will fail due to ~5 different problems.

To reproduce, add `compatibility='CPython>=3.5',` to `pants_test/util/BUILD` entry of `meta`, then run
```
./pants test tests/python/pants_test/util:meta
```

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Python 3 fixes - fix dirutil, fileutil, and xml_parser tests (pantsbu…
…ild#6229)

### Problem
Dirutil tests failing due to unicode vs bytes. 

`dirutil.py` itself is fine. I decided `safe_file_dump()` and `read_file()` should still work with bytes, not unicode.

### Related PRs
To get completely green on Py3, requires pantsbuild#6226 and pantsbuild#6228. This can be merged before them both, though, as it shouldn't break Py2 and we aren't running Py3 yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment