New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spurious deprecation warning for fatal_warnings #6237

Merged
merged 1 commit into from Jul 25, 2018

Conversation

Projects
None yet
3 participants
@stuhood
Copy link
Member

stuhood commented Jul 25, 2018

Problem

zinc_language_mixin.py accesses its own deprecated property to get the fatal_warnings option value, which triggers a guaranteed warning.

Solution

Directly consume the fatal_warnings option value to avoid triggering the deprecation warning for the property access.

Directly consume the fatal_warnings option value to avoid triggering …
…the deprecation warning for the property.

@stuhood stuhood added this to the 1.9.x milestone Jul 25, 2018

@stuhood stuhood requested review from cosmicexplorer and alanbato Jul 25, 2018

@alanbato
Copy link
Member

alanbato left a comment

LGTM!

@stuhood stuhood merged commit de4f02f into pantsbuild:master Jul 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/zinc-language-mixin-triggering-warning branch Jul 25, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Jul 25, 2018

@cosmicexplorer : FYI: Cherry picking this to 1.9.x.

stuhood added a commit that referenced this pull request Jul 25, 2018

Fix spurious deprecation warning for fatal_warnings (#6237)
### Problem

`zinc_language_mixin.py` accesses its own deprecated property to get the fatal_warnings option value, which triggers a guaranteed warning.

### Solution

Directly consume the fatal_warnings option value to avoid triggering the deprecation warning for the property access.

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Fix spurious deprecation warning for fatal_warnings (pantsbuild#6237)
### Problem

`zinc_language_mixin.py` accesses its own deprecated property to get the fatal_warnings option value, which triggers a guaranteed warning.

### Solution

Directly consume the fatal_warnings option value to avoid triggering the deprecation warning for the property access.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment