New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a debug dump flag to the zinc analysis extractor #6241

Merged
merged 1 commit into from Jul 26, 2018

Conversation

Projects
None yet
2 participants
@stuhood
Copy link
Member

stuhood commented Jul 26, 2018

Problem

Testing analysis portability externally to zinc is not straightforward, because individual fields not being made portable do not necessarily cause loud failures, or even actual failures to compile incrementally.

This test confirms one type of portability: https://github.com/pantsbuild/pants/blob/master/tests/python/pants_test/backend/jvm/tasks/jvm_compile/java/test_cache_compile_integration.py#L167, but there are other forms that can cause silent failures. See #6239 for an example.

Solution

Re-introduce the ability to dump analysis as text, to be used for integration tests that confirm that no references to previous workspaces are included.

@stuhood stuhood requested review from baroquebobcat , illicitonion and ity Jul 26, 2018

@baroquebobcat
Copy link
Contributor

baroquebobcat left a comment

lgtm!

@stuhood stuhood merged commit 0981862 into pantsbuild:master Jul 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/add-debug-analysis-extraction branch Jul 26, 2018

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Add a debug dump flag to the zinc analysis extractor. (pantsbuild#6241)
### Problem

Testing analysis portability externally to zinc is not straightforward, because individual fields not being made portable do not necessarily cause loud failures, or even actual failures to compile incrementally. 

This test confirms one type of portability: https://github.com/pantsbuild/pants/blob/master/tests/python/pants_test/backend/jvm/tasks/jvm_compile/java/test_cache_compile_integration.py#L167, but there are other forms that can cause silent failures. See pantsbuild#6239 for an example.

### Solution

Re-introduce the ability to dump analysis as text, to be used for integration tests that confirm that no references to previous workspaces are included.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment