New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 fixes - exclude faulthandler and futures if Py3 #6244

Merged
merged 1 commit into from Jul 28, 2018

Conversation

Projects
None yet
3 participants
@Eric-Arellano
Copy link
Contributor

Eric-Arellano commented Jul 26, 2018

Both these libraries are not supported in Py3, as they are backports.

@kwlzn

kwlzn approved these changes Jul 27, 2018

@kwlzn kwlzn merged commit 46d0fcd into pantsbuild:master Jul 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

stuhood added a commit that referenced this pull request Jul 28, 2018

Python 3 fixes - fix base folder (#6252)
Everything should be green with Py2 and Py3, excluding the native engine issue discussed on Slack + pending PRs #6251, #6245, and #6244.

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:py3-fixes_exclude-faulthandler-and-futures branch Jul 30, 2018

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Exclude faulthandler and futures if Python 3 (pantsbuild#6244)
Both these libraries are not supported in Py3, as they are backports.

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Python 3 fixes - fix base folder (pantsbuild#6252)
Everything should be green with Py2 and Py3, excluding the native engine issue discussed on Slack + pending PRs pantsbuild#6251, pantsbuild#6245, and pantsbuild#6244.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment