New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split file set by line instead of spaces to resolve errors #6247

Merged
merged 2 commits into from Jul 28, 2018

Conversation

Projects
None yet
4 participants
@dotordogh
Copy link
Contributor

dotordogh commented Jul 27, 2018

Solves #6161

Dorothy Ordogh added some commits Jul 27, 2018

@dotordogh dotordogh requested a review from baroquebobcat Jul 27, 2018

@stuhood
Copy link
Member

stuhood left a comment

Thanks!

@baroquebobcat
Copy link
Contributor

baroquebobcat left a comment

Looks good.

It'd be nice if there were an integration test, but I'm not quite sure where it should live, since it would be good to cover spaces in filenames for a number of use cases. I don't think it's blocking in this case though.

@stuhood stuhood merged commit 93a5f05 into pantsbuild:master Jul 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

stuhood added a commit to twitter/pants that referenced this pull request Aug 12, 2018

stuhood added a commit to twitter/pants that referenced this pull request Aug 12, 2018

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment