Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Python 3 fixes - fix scm bytes vs unicode issues #6257
This folder had a lot of issues with intermixing unicode and bytes.
While I think some of it can be refactored to use unicode (simpler to deal with), I tried to stop myself from doing this and to stay as true to the original semantics as possible.
Tests now pass locally in Py2 and Py3.
Good catch with the unnecessary joins, you're definitely right and it works with those removed. Which then means I 100% agree with you that
We do still need to convert into the list within
Thanks for reviewing this closely!