New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 fixes - bump beautifulsoup4 to 4.6 #6260

Merged
merged 1 commit into from Jul 28, 2018

Conversation

Projects
None yet
2 participants
@Eric-Arellano
Copy link
Contributor

Eric-Arellano commented Jul 28, 2018

Problem

Beautifulsoup4 version 4.3 doesn't run on Python 3.5+, due to a change made to the standard library.

See https://stackoverflow.com/questions/28745153/importing-bs4-in-python-3-5.

Solution

Bumping from 4.3 to 4.6, the newest version. We can technically get away with 4.4 if we want to reduce the scope of bump, although the changelog looks fairly innocuous.

Testing

Ran below in Py2 and Py3 mode (by changing BUILD's compatibility). Py3 still fails due to issues I'll address in another PR, but it no longer gives the beautifulsoup problem.

./pants run src/python/pants/releases:packages -- list
./pants run src/python/pants/releases:packages -- list-owners
./pants run src/python/pants/releases:packages -- check-my-ownership

@stuhood stuhood merged commit 1f5181b into pantsbuild:master Jul 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:py3-fixes_beautifulsoup branch Jul 29, 2018

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Bump beautifulsoup4 to 4.6 to fix Python 3 issue. (pantsbuild#6260)
## Problem
Beautifulsoup4 version 4.3 doesn't run on Python 3.5+, due to a change made to the standard library.  

See https://stackoverflow.com/questions/28745153/importing-bs4-in-python-3-5.

## Solution
Bumping from 4.3 to 4.6, the newest version. We can technically get away with 4.4 if we want to reduce the scope of bump, although the [changelog](https://bazaar.launchpad.net/~leonardr/beautifulsoup/bs4/view/head:/NEWS.txt) looks fairly innocuous.

## Testing
Ran below in Py2 and Py3 mode (by changing BUILD's compatibility). Py3 still fails due to issues I'll address in another PR, but it no longer gives the beautifulsoup problem.
```
./pants run src/python/pants/releases:packages -- list
./pants run src/python/pants/releases:packages -- list-owners
./pants run src/python/pants/releases:packages -- check-my-ownership
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment