New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 fixes - fix mock options test util - unicode vs bytes issues #6263

Merged
merged 1 commit into from Jul 29, 2018

Conversation

Projects
None yet
2 participants
@Eric-Arellano
Copy link
Contributor

Eric-Arellano commented Jul 28, 2018

This file is used by multiple tests to mock options, so I'm breaking it out into separate PR.

@Eric-Arellano

This comment has been minimized.

Copy link
Contributor

Eric-Arellano commented Jul 29, 2018

Don't merge this one yet. I found none of the fake values are actually being populated with Py3, at least when testing contrib/go.

I'll add that fix to this PR once ready.

@Eric-Arellano

This comment has been minimized.

Copy link
Contributor

Eric-Arellano commented Jul 29, 2018

Nevermind.. the same lines of code were causing a different problem, but the solution is the same. I had the contrib branch I'm working on starting from master, rather than this, so went on a wild goose chase to arrive at the same code changes.

So, to be clear, this PR is ready to go, beyond this job timing out https://travis-ci.org/pantsbuild/pants/jobs/409403891.

@jsirois jsirois merged commit 222c8f0 into pantsbuild:master Jul 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:py3-fixes_fake-options-fix branch Jul 29, 2018

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment