New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 fixes - fix test_base.create_files() unicode issue #6266

Merged
merged 1 commit into from Jul 29, 2018

Conversation

Projects
None yet
2 participants
@Eric-Arellano
Copy link
Contributor

Eric-Arellano commented Jul 28, 2018

Same thing happened while testing docgen - found an issue with an unrelated folder so breaking this out into separate PR. Let me know if these are too small and I should just combine with the PR for where I found the issue, e.g. #6265

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Jul 29, 2018

Let me know if these are too small and I should just combine with the PR for where I found the issue, e.g. #6265

They could stand to be a bit larger, yea. The "one per module" approach made sense for the initial pass, but aggregating a bit more now would be ok.

@stuhood stuhood merged commit afa8150 into pantsbuild:master Jul 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:py3-fixes_test-base-create-files branch Jul 30, 2018

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment