New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 1.10.x deprecations #6268

Merged
merged 10 commits into from Jul 30, 2018

Conversation

Projects
None yet
5 participants
@stuhood
Copy link
Member

stuhood commented Jul 29, 2018

To unblock #6249.

I've also bumped a few: the BaseTest removal is going to take a little bit longer, but when it goes it will kill a lot of dead code.

@stuhood stuhood requested review from jsirois , benjyw and illicitonion Jul 29, 2018

@stuhood stuhood referenced this pull request Jul 29, 2018

Merged

Prep for 1.10.0dev0 #6249

@stuhood stuhood force-pushed the twitter:stuhood/deprecations-for-1.10.x branch from 9704d8a to ac0ff76 Jul 29, 2018

@@ -24,13 +23,6 @@ def __init__(self, excludes_path, log):
pattern, plugins = line.strip().split('::', 2)
plugins = plugins.split()

deprecated_conditional(
lambda: 'pep8' in plugins,

This comment has been minimized.

@jsirois

jsirois Jul 30, 2018

Member

There's a conditional just below (with disturbing indent irregularity!) that can be removed now. I think in fact the whole style_plugins collection loop can be killed and style_plugins = plugins.split() above.

@benjyw

benjyw approved these changes Jul 30, 2018

@illicitonion illicitonion merged commit 14bfee2 into pantsbuild:master Jul 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/deprecations-for-1.10.x branch Jul 30, 2018

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Remove 1.10.x deprecations (pantsbuild#6268)
* Remove SimpleCodegenTask.find_sources

* Remove list-owners

* Remove `ivy_cache_dir`

* Remove pep8/pycodestyle hint.

* Remove deprecated pycheck-pep8 scope.

* Remove deprecated use_nailgun option.

* Bump BaseTest and TargetMacro.Factory target_type deprecations. Should all be pruned together.

* Remove follow_links kwarg deprecation.

* Bump target source/sources unification warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment