New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the `alias` page to actually reference the `alias` target #6277

Merged
merged 3 commits into from Aug 1, 2018

Conversation

Projects
None yet
2 participants
@guymarom
Copy link
Contributor

guymarom commented Jul 30, 2018

Modified the alias page and other pages referring it.
Introduced a new "target aggregate" concept (as opposed to "target alias")
for the target target.

Modify the `alias` page to actually reference the `alias` target
Modified the page and other pages referring it.
Introduced a new "target aggregate" concept (as opposed to "target alias")
for the `target` target.

@guymarom guymarom force-pushed the guymarom:master branch from 0795b61 to 563e5c3 Jul 30, 2018

@stuhood
Copy link
Member

stuhood left a comment

Thanks! Few minor fixes.

@@ -32,16 +32,14 @@ In addition, Pants commands would be similarly verbose:

$ ./pants compile myproject/src/main/scala/com/twitter/myproject:scala

You can simplify this by creating a `target` definition in a `BUILD` file
You can simplify this by creating an `alias` definition in a `BUILD` file
stored in a more convenient location in the directory tree, for example in the root directory. Here's an example:


:: python
# myproject/BUILD
target(name='myproject',

This comment has been minimized.

@stuhood

stuhood Jul 30, 2018

Member

This should be an alias now.

This comment has been minimized.

@guymarom

guymarom Jul 31, 2018

Contributor

OK


## Solution

Use the `target` goal and specify an aggregate target that depends on all the targets you wish to run

This comment has been minimized.

@stuhood

stuhood Jul 30, 2018

Member

Maybe say "Use a literal target definition in your BUILD file to specify..."

This comment has been minimized.

@guymarom

guymarom Jul 31, 2018

Contributor

OK


Use the `target` goal and specify an aggregate target that depends on all the targets you wish to run

Here's an example `target` definition that creates a target names `agg` dependent on two modules `dep1` and `dep2`:

This comment has been minimized.

@stuhood

stuhood Jul 30, 2018

Member

named

This comment has been minimized.

@guymarom

guymarom Jul 31, 2018

Contributor

OK

# agg/BUILD
target(name='agg',
dependencies=[
'myproject/src/main/scala/com/twitter/myproject/subproject/dep1:scala'

This comment has been minimized.

@stuhood

stuhood Jul 30, 2018

Member

These should be separated by commas.

This comment has been minimized.

@guymarom

guymarom Jul 31, 2018

Contributor

OK

@guymarom

This comment has been minimized.

Copy link
Contributor

guymarom commented Jul 31, 2018

@stuhood I fixed everything that needed fixing, thanks for the review.

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Jul 31, 2018

Thank you! Will merge this when master is green.

@stuhood stuhood merged commit 492acb2 into pantsbuild:master Aug 1, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Aug 1, 2018

The only failures here are due to #6285, which is now fixed. Merging.

Thanks @guymarom !

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Modify the `alias` page to actually reference the `alias` target (pan…
…tsbuild#6277)

Modified the `alias` page and other pages referring it.
Introduced a new "target aggregate" concept (as opposed to "target alias")
for the `target` target.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment