New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill WrappedPEX. #6280

Merged
merged 4 commits into from Aug 1, 2018

Conversation

Projects
None yet
2 participants
@jsirois
Copy link
Member

jsirois commented Jul 30, 2018

There is no longer any apparent need for this.

@jsirois jsirois requested review from benjyw and CMLivingston Jul 30, 2018

@benjyw

benjyw approved these changes Jul 31, 2018

@jsirois jsirois force-pushed the jsirois:issues/5922/followup-kill-WrappedPEX branch from 0ef7ddb to 98948a3 Aug 1, 2018

jsirois added some commits Jul 30, 2018

Kill WrappedPEX.
There is no longer any apparent need for this.
Fixup PythonEval use of pex_path.
Now that the pex_path is sealed into the entrypoint pex, it must be
re-created whenever its requirements or sources pex dependencies have
changed.
Fix access of invalid PEX.interpreter.
This was un-needed anyhow since PEX already has cmdline to
encapsulate extracting a full command line.

@jsirois jsirois force-pushed the jsirois:issues/5922/followup-kill-WrappedPEX branch from 98948a3 to a898f6e Aug 1, 2018

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Aug 1, 2018

@benjyw there was enough change to right the CI ship that this is worth another look.

@@ -45,15 +45,14 @@ class BarB(object):
pass
""")})

# TODO: Presumably this was supposed to be c_library, not override b_library. Unravel and fix.

This comment has been minimized.

@benjyw

benjyw Aug 1, 2018

Contributor

That was my TODO from 3 years ago! Thanks for fixing.

@benjyw

benjyw approved these changes Aug 1, 2018

@jsirois jsirois merged commit a76aa33 into pantsbuild:master Aug 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:issues/5922/followup-kill-WrappedPEX branch Aug 1, 2018

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Kill WrappedPEX. (pantsbuild#6280)
There is no longer any apparent need for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment