New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bound pytest below 3.7 to avoid a ZipImportError #6285

Merged
merged 1 commit into from Aug 1, 2018

Conversation

Projects
None yet
2 participants
@stuhood
Copy link
Member

stuhood commented Jul 31, 2018

Problem

As described in #6282, pytest 3.7 introduces a non-deterministic ZipImportError.

Solution

Bound pants' usage of pytest below 3.7. This subsumes #6283: the hypothesis is that because tests/python/pants_test/backend/python/tasks/test_pytest_run.py creates synthetic scopes for its tasks, options in pants.ini (as opposed to Subsystem defaults) are not applied.

Result

Works around #6282.

@stuhood stuhood requested review from jsirois and benjyw Jul 31, 2018

@jsirois
Copy link
Member

jsirois left a comment

Thanks for tracking this down.

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Aug 1, 2018

Blargh. Two isolated_process timeouts in a row. Going to merge.

@stuhood stuhood merged commit bd434de into pantsbuild:master Aug 1, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@stuhood stuhood deleted the twitter:stuhood/avoid-pytest-gte-3.7 branch Aug 1, 2018

@jsirois jsirois referenced this pull request Aug 1, 2018

Closed

Avoid pytest 3.7.0+. #6283

@stuhood stuhood added this to the 1.9.x milestone Aug 1, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Aug 1, 2018

Going to eagerly pick this to both 1.8.x and 1.9.x.

stuhood added a commit that referenced this pull request Aug 1, 2018

Bound pytest below 3.7 to avoid a ZipImportError (#6285)
### Problem

As described in #6282, pytest `3.7` introduces a non-deterministic `ZipImportError`.

### Solution

Bound pants' usage of pytest below `3.7`. This subsumes #6283: the hypothesis is that because `tests/python/pants_test/backend/python/tasks/test_pytest_run.py` creates synthetic scopes for its tasks, options in `pants.ini` (as opposed to Subsystem defaults) are not applied. 

### Result

Works around #6282.

stuhood added a commit to twitter/pants that referenced this pull request Aug 1, 2018

Bound pytest below 3.7 to avoid a ZipImportError (pantsbuild#6285)
### Problem

As described in pantsbuild#6282, pytest `3.7` introduces a non-deterministic `ZipImportError`.

### Solution

Bound pants' usage of pytest below `3.7`. This subsumes pantsbuild#6283: the hypothesis is that because `tests/python/pants_test/backend/python/tasks/test_pytest_run.py` creates synthetic scopes for its tasks, options in `pants.ini` (as opposed to Subsystem defaults) are not applied. 

### Result

Works around pantsbuild#6282.

@stuhood stuhood modified the milestones: 1.9.x, 1.8.x Aug 1, 2018

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Bound pytest below 3.7 to avoid a ZipImportError (pantsbuild#6285)
### Problem

As described in pantsbuild#6282, pytest `3.7` introduces a non-deterministic `ZipImportError`.

### Solution

Bound pants' usage of pytest below `3.7`. This subsumes pantsbuild#6283: the hypothesis is that because `tests/python/pants_test/backend/python/tasks/test_pytest_run.py` creates synthetic scopes for its tasks, options in `pants.ini` (as opposed to Subsystem defaults) are not applied. 

### Result

Works around pantsbuild#6282.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment