New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 fixes - fix issues with binaries, option, pantsd, java, and build graph #6287

Merged
merged 10 commits into from Aug 1, 2018

Conversation

Projects
None yet
2 participants
@Eric-Arellano
Copy link
Contributor

Eric-Arellano commented Aug 1, 2018

No description provided.

@stuhood

stuhood approved these changes Aug 1, 2018

Copy link
Member

stuhood left a comment

Thanks. Some nits which can be fixed in followups.

"the current host platform (u\'darwin\', u\'999\').\\n--binaries-path-by-id was:")
"the current host platform ({unicode_literal}\'darwin\', {unicode_literal}\'999\').\\n--binaries-path-by-id was:"
).format(unicode_literal='u' if PY2 else '')
# expected_msg_postfix = ".\\n--binaries-path-by-id was:"

This comment has been minimized.

@stuhood

stuhood Aug 1, 2018

Member

Unused.


def test_unicode_string_in_build_file(self):
"""Demonstrates that a string containing unicode should work in a BUILD file."""
# TODO(python3port): remove ensure_binary once safe_open() uses backport. This test fails on Py3.

This comment has been minimized.

@stuhood

stuhood Aug 1, 2018

Member

Less important here, but in general TODOs should be targeted at tickets rather than people or topics.

This comment has been minimized.

@Eric-Arellano

Eric-Arellano Aug 1, 2018

Contributor

John and I discussed use the approach to add # TODO(python3port) and then track here #6071

I didn't add these to issue because I'll be fixing it in next few days as part of migration, whereas in general this is meant to be things that are issues discovered during migration but not immediately necessary to fix.

This comment has been minimized.

@stuhood

stuhood Aug 1, 2018

Member

Then the TODO could reference #6071 presumably?

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Aug 1, 2018

Discussed the CI failure offline, and will save some travis time by merging now.

@stuhood stuhood merged commit 1fbc8fb into pantsbuild:master Aug 1, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:py3-fixes_unit-tests branch Aug 1, 2018

illicitonion added a commit that referenced this pull request Aug 7, 2018

Python 3 fixes - various bytes vs unicode issues (#6311)
Fixes multiple issues resulting from running unit tests in Python 3.

Addresses the folders not covered by earlier sweep made by #6287.

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Python 3 fixes - fix issues with binaries, option, pantsd, java, and …
…build graph (pantsbuild#6287)

* Fix binaries tests

* Replace configparser deprecations & use backport

* Fix option test unicode vs bytes issues

* Fix option test iteration through DeprecationWarning

* Make nested class Exception calls explicit

* Fix pantsd unicode vs bytes issues

* Fix issues with java/jar and java/distribution

* Fix issues with java folder and nailgun

* Fix build graph Py3 issues

* Fix bad bootstrap_dir. Changed it to get tests passing on Mac.

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Python 3 fixes - various bytes vs unicode issues (pantsbuild#6311)
Fixes multiple issues resulting from running unit tests in Python 3.

Addresses the folders not covered by earlier sweep made by pantsbuild#6287.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment