Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix a deadlock in local process execution. #6292
NB: I did not dig too far into where our hand-rolled stream-collection might be deadlocking. My only hunch was that stdin was not dealt with, but you'd expect tokio-process would handle
This is basically a revert of #6105 which is a shame because that was a useful direction to be going, both to support timeouts, and to support streaming for console rules in the future... It would be good for someone (one of me, @jsirois, or @stuhood, I guess) to do a little poking at what's wrong with the logic before blowing it away...