New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop self from __init__ and __new__ #6299

Merged
merged 1 commit into from Aug 3, 2018

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

illicitonion commented Aug 3, 2018

An alternative would be to just always drop the first arg if its name is
self (or maybe cls). But this is the minimally invasive change for
py3 compat.

drop self from __init__ and __new__
An alternative would be to just always drop the first arg if its name is
`self` (or maybe `cls`). But this is the minimally invasive change for
py3 compat.

@illicitonion illicitonion requested a review from stuhood Aug 3, 2018

@Eric-Arellano

This comment has been minimized.

Copy link
Contributor

Eric-Arellano commented Aug 3, 2018

Nice, thanks for looking into this!

@stuhood

stuhood approved these changes Aug 3, 2018

@illicitonion illicitonion merged commit eeca587 into pantsbuild:master Aug 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/py3/help branch Aug 3, 2018

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

drop self from __init__ and __new__ (pantsbuild#6299)
An alternative would be to just always drop the first arg if its name is
`self` (or maybe `cls`). But this is the minimally invasive change for
py3 compat.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment