New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten up local process streaming. #6307

Merged
merged 2 commits into from Aug 6, 2018

Conversation

Projects
None yet
2 participants
@jsirois
Copy link
Member

jsirois commented Aug 5, 2018

We now guaranty the local process is configured for streaming and have
a bit cleaner line to demarc where future streaming would be inserted.

Tighten up local process streaming.
We now guaranty the local process is configured for streaming and have
a bit cleaner line to demarc where future streaming would be inserted.

@jsirois jsirois requested review from stuhood and illicitonion Aug 5, 2018

// It would be really nice not to have to manually set PATH but this is sadly the only way
// to stop automatic PATH searching.
.env("PATH", "")
.stdin(Stdio::null())

This comment has been minimized.

@jsirois

jsirois Aug 5, 2018

Member

Move stream configuration to the stream method where it's relied upon.

This comment has been minimized.

@jsirois

jsirois Aug 6, 2018

Member

Done.

}

impl ChildResults {
fn collect_from<S, E>(stream: S) -> impl Future<Item = ChildResults, Error = E>

This comment has been minimized.

@jsirois

jsirois Aug 5, 2018

Member

Perhaps try impl Future in argument position

This comment has been minimized.

@jsirois

jsirois Aug 6, 2018

Member

Done.

@stuhood

stuhood approved these changes Aug 6, 2018

Copy link
Member

stuhood left a comment

Thanks.

@jsirois jsirois merged commit ee5241f into pantsbuild:master Aug 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:local_process/tighten_up_streaming branch Aug 6, 2018

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Tighten up local process streaming. (pantsbuild#6307)
We now guaranty the local process is configured for streaming and have
a bit cleaner line to demarc where future streaming would be inserted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment