New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache more of rust. #6309

Merged
merged 2 commits into from Aug 7, 2018

Conversation

Projects
None yet
3 participants
@jsirois
Copy link
Member

jsirois commented Aug 6, 2018

Picks the lowest hanging fruit from #6119.

.travis.yml Outdated
- rm -rf ${HOME}/.cache/pants/bin
- rm -rf ${HOME}/.cache/pants/rust/rustup

This comment has been minimized.

@illicitonion

illicitonion Aug 6, 2018

Contributor

This directory is basically just wget'd by rustup; does caching it really give a noticeable improvement?

This comment has been minimized.

@jsirois

jsirois Aug 6, 2018

Member

I'm not sure - I did not isolate the two halves and test. I just setup the same caching Travis sets up for cache: cargo as noted in the associated issue. I'll run some experiments.

This comment has been minimized.

@stuhood

stuhood Aug 6, 2018

Member

Yea, would be good to isolate the two changes... caching the target directory makes a lot of sense, but this one maybe less so.

This comment has been minimized.

@jsirois

jsirois Aug 6, 2018

Member

Restored.

jsirois added some commits Aug 6, 2018

Cache more of rust.
Picks the lowest hanging fruit from #6119.

@jsirois jsirois force-pushed the jsirois:issues/6119 branch from cf295df to fe53de4 Aug 6, 2018

@illicitonion
Copy link
Contributor

illicitonion left a comment

Thanks!

@stuhood

stuhood approved these changes Aug 7, 2018

@jsirois jsirois merged commit b0d5841 into pantsbuild:master Aug 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:issues/6119 branch Aug 7, 2018

illicitonion added a commit to twitter/pants that referenced this pull request Aug 8, 2018

Revert "Cache more of rust. (pantsbuild#6309)"
This reverts commit b0d5841.

We've started seeing internal compiler exceptions on travis during rust
compilation mentioning inconsistent state on disk.

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Cache more of rust. (pantsbuild#6309)
Picks the lowest hanging fruit from pantsbuild#6119.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment