New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dependency ClasspathEntries, not merged strings #6317

Merged
merged 2 commits into from Aug 9, 2018

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

illicitonion commented Aug 8, 2018

This will allow the optional DirectoryDigest to be used in hermetic
execution.

The reason for changing this to be just dependencies, and have the
compile function add the target's classpath itself, is that otherwise we
need to make an artificial ClasspathEntry for the current target, which
seems convoluted.

Use dependency ClasspathEntries, not merged strings
This will allow the optional DirectoryDigest to be used in hermetic
execution.

The reason for changing this to be just dependencies, and have the
compile function add the target's classpath itself, is that otherwise we
need to make an artificial ClasspathEntry for the current target, which
seems convoluted.

@illicitonion illicitonion requested review from baroquebobcat and stuhood Aug 8, 2018

@stuhood

stuhood approved these changes Aug 8, 2018

@illicitonion illicitonion merged commit f7f652c into pantsbuild:master Aug 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/remotezinc/classpath branch Aug 9, 2018

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Use dependency ClasspathEntries, not merged strings (pantsbuild#6317)
This will allow the optional DirectoryDigest to be used in hermetic
execution.

The reason for changing this to be just dependencies, and have the
compile function add the target's classpath itself, is that otherwise we
need to make an artificial ClasspathEntry for the current target, which
seems convoluted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment