New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip known to fail tests in py3 #6323

Merged
merged 4 commits into from Aug 10, 2018

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

illicitonion commented Aug 9, 2018

No description provided.

@stuhood
Copy link
Member

stuhood left a comment

This will skip them for both Py2 and Py3, I think?

@stuhood

stuhood approved these changes Aug 9, 2018

Copy link
Member

stuhood left a comment

Thanks!

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/py3/suppress branch 2 times, most recently from 9341082 to 067991b Aug 9, 2018

@illicitonion illicitonion referenced this pull request Aug 10, 2018

Open

Porting to Python 3 #6062

5 of 7 tasks complete

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/py3/suppress branch from 067991b to 3f24ef4 Aug 10, 2018

)
fingerprint = fingerprinter.fingerprint(option_type, option_value)
if fingerprint is None:
fingerprint = 'None'

This comment has been minimized.

@illicitonion

illicitonion Aug 10, 2018

Contributor

I realise this is strange, but six.binary_type(None) == 'None' so this is behaviour preserving. Maybe not correct, but behaviour preserving :)

This comment has been minimized.

@wisechengyi

wisechengyi Aug 10, 2018

Contributor

Worth noting as a comment?

This comment has been minimized.

@illicitonion

illicitonion Aug 10, 2018

Contributor

Done

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/py3/suppress branch from 3f24ef4 to 05ca467 Aug 10, 2018

illicitonion added some commits Aug 10, 2018

Fix Scopes
Python2 | behaviour of things which inherit from frozenset is to return
the subclass.

Python3 behaviour is to return a frozenset.

This gives consistent behaviour across both.

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/py3/suppress branch from 5d57692 to a563619 Aug 10, 2018

@stuhood
Copy link
Member

stuhood left a comment

Thanks.

@illicitonion illicitonion merged commit aad3a3c into pantsbuild:master Aug 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/py3/suppress branch Aug 10, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Aug 10, 2018

Wohoo.

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Skip known to fail tests in py3 (pantsbuild#6323)
Also fix a bunch of tests to be py3 compatible

* Fix Scopes

Python2 | behaviour of things which inherit from frozenset is to return
the subclass.

Python3 behaviour is to return a frozenset.

This gives consistent behaviour across both.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment