New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings are correctly returned from rust code #6325

Merged
merged 1 commit into from Aug 9, 2018

Conversation

Projects
None yet
2 participants
@illicitonion
Copy link
Contributor

illicitonion commented Aug 9, 2018

Currently we're stringifying a buffer, which on py2 is fine, and on py3 is horribly wrong.

@illicitonion illicitonion requested a review from stuhood Aug 9, 2018

@stuhood

stuhood approved these changes Aug 9, 2018

Copy link
Member

stuhood left a comment

Thanks!

Would be good to get #6323 landed, and a procedure in place for unskipping things.

@illicitonion illicitonion merged commit 81c9769 into pantsbuild:master Aug 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/py3/strings branch Aug 9, 2018

cosmicexplorer added a commit to cosmicexplorer/pants that referenced this pull request Aug 10, 2018

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment