New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log test targets that failed to run. #6335

Merged
merged 1 commit into from Aug 10, 2018

Conversation

Projects
None yet
4 participants
@jsirois
Copy link
Member

jsirois commented Aug 10, 2018

Previously these would log as successes, now we warn that they did not
run prior to failing the pants run as a whole.

Fixes #6334

Log test targets that failed to run.
Previously these would log as successes, now we warn that they did not
run prior to failing the pants run as a whole.

Fixes #6334
@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Aug 10, 2018

Now we get:

image

@jsirois jsirois requested a review from benjyw Aug 10, 2018

@benjyw

benjyw approved these changes Aug 10, 2018

Copy link
Contributor

benjyw left a comment

Thanks for the quick fix!

@jsirois jsirois merged commit c329660 into pantsbuild:master Aug 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:issues/6334 branch Aug 11, 2018

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Log test targets that failed to run. (pantsbuild#6335)
Previously these would log as successes, now we warn that they did not
run prior to failing the pants run as a whole.

Fixes pantsbuild#6334
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment