Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix Single Address Exclude #6366
The git commit hook (and CI lint) will lint targets that own changed files. Transforming specs to single addresses is currently broken and causes a "did you mean error" to be thrown on specs that actually exist in an affected build file:
This manifested after trying to make changes to a
Edit build_files.py to aggregate excluded addresses in addition to included ones and check that excluded addresses align with exclude logic so that the "did you mean" error only occurs when the spec actually doesn't exist.
Changes to files in testprojects will not throw any "did you mean" errors in CI/commit hook lint invoked by the following command:
Thanks for the reviews all. This is strange, I rebased master before pushing these changes, and I didn’t make any of the 2/3 comparability or formatting changes that appear here. Is there a futurize or autofmt script running as part of the git hook or something? Otherwise this was definitely an accident and Ill revert those.