New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize test case sorting in suites. #6371

Merged
merged 1 commit into from Aug 21, 2018

Conversation

Projects
None yet
3 participants
@jsirois
Copy link
Member

jsirois commented Aug 21, 2018

Fixes #6370

@jsirois jsirois requested a review from stuhood Aug 21, 2018

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Aug 21, 2018

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Aug 21, 2018

OK - this change made the following go from a ~50% failure rate to 47 successes in a row:

./pants \
  --python-setup-interpreter-constraints='["CPython>=3.4,<3.5"]' \
  --owner-of=tests/python/pants_test/backend/jvm/tasks/reports/test_junit_html_report.py \
  test.pytest --cache-ignore -- -vsktest_merged_conflict_first
@Eric-Arellano

This comment has been minimized.

Copy link
Contributor

Eric-Arellano commented Aug 21, 2018

Looks great. Thanks for digging into this John!

@jsirois jsirois merged commit f07c063 into pantsbuild:master Aug 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:issues/6370 branch Aug 21, 2018

ity added a commit to ity/pants that referenced this pull request Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment