Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Python 3 - fixes to get most of src unit tests green #6372
Earlier I was planning on breaking this out into several smaller PRs, but now that I got the integration tests to pass, I'm hoping to keep this as one.
The remaining issue is getting releases to work. I can reproduce locally, but the results seem slightly non-deterministic? Originally I git bisected to 5347cad, but then after incrementelly rebuilding that commit it suddenly was passing. Another time I git bisected to eb4372b. So, while I'm able to get failures locally, I can't determine what the issue is or why it doesn't consistently fail.
Tomorrow is my busiest day of school week if anyone has time to look, otherwise I'll get to it tomorrow or Thursday. (Probably more helpful to address the other issues, though, especially #6382 because I can't repro locally.)
referenced this pull request
Aug 22, 2018
@benjyw I'm still on flight and don't have WiFi on work laptop or access to Slack, but have internet on personal computer and was able to trigger a rebase from GitHub's web app.
Would be great to include this in release if it's still within the timeline. Thanks!
Thanks for the close review!
Agreed let’s punt that one failing test - this is actually the first time I’ve seen the failure, and I think it’s due to Py3.4’s dictionary randomness (which I discovered we can turn on for python 2!)
Will fix your suggestions in a couple hours when I’m free.