New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer timeout test_pinger.py #6373

Merged
merged 1 commit into from Aug 27, 2018

Conversation

Projects
None yet
3 participants
@Eric-Arellano
Copy link
Contributor

Eric-Arellano commented Aug 21, 2018

Problem

We were originally expecting failure from test_pinger.py specifically because it would timeout often on CI, so was flakey.

However, the tests seem to perform more rapidly with Py3, so they were passing -> red CI for Py3 because the tests are supposed to fail.

Solution

Simply up the timeout for these tests.

Expecting failure doesn't seem to make sense, because they are meaningful tests, just take longer than normal unit tests. We want to know when we break the functionality, which expecting failure doesn't give us.

Convert to integration test?

Should we add the integration tag? These don't seem like unit tests with such a generous timeout policy.

@stuhood
Copy link
Member

stuhood left a comment

Thanks!

@benjyw benjyw merged commit b1aca5d into pantsbuild:master Aug 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:test-pinger-timeout branch Aug 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment