Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
No longer timeout test_pinger.py #6373
We were originally expecting failure from
However, the tests seem to perform more rapidly with Py3, so they were passing -> red CI for Py3 because the tests are supposed to fail.
Simply up the timeout for these tests.
Expecting failure doesn't seem to make sense, because they are meaningful tests, just take longer than normal unit tests. We want to know when we break the functionality, which expecting failure doesn't give us.
Convert to integration test?
Should we add the integration tag? These don't seem like unit tests with such a generous timeout policy.