Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode python_eval template resource as utf-8. #6379

Merged
merged 2 commits into from Aug 22, 2018

Commits on Aug 22, 2018

  1. Decode python_eval template resource as utf-8.

    Without this, the template was rendered with literal `\n`'s under
    python3. I did not linger to figure out how the rendered string could
    possibly load in a python interpreter with no errors!
    
    Fixes pantsbuild#6354
    jsirois committed Aug 22, 2018
    Copy the full SHA
    705d634 View commit details
    Browse the repository at this point in the history
  2. Fix the BuildInvalidator.

    Previously it wrote and read keys asymmetrically; now the key is
    uniformly represented (and compared!) as a unicode utf-8 string in
    memory.
    jsirois committed Aug 22, 2018
    Copy the full SHA
    053fb46 View commit details
    Browse the repository at this point in the history