New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HEAD redirects in RESTfulArtifactCache. #6412

Merged
merged 1 commit into from Aug 29, 2018

Conversation

Projects
None yet
2 participants
@jsirois
Copy link
Member

jsirois commented Aug 29, 2018

Tests are modifed such that if any of the four API methods do not
follow redirects, we get a test failure.

Fixes #6411

Support HEAD redirects in RESTfulArtifactCache.
Tests are modifed such that if any of the four API methods do not
follow redirects, we get a test failure.

Fixes #6411
@@ -108,13 +108,23 @@ def _request(self, method, cache_key, body=None):
logger.debug('Sending {0} request to {1}'.format(method, url))
try:
if 'PUT' == method:
response = session.put(url, data=body, timeout=self._write_timeout_secs)
response = session.put(url,

This comment has been minimized.

@jsirois

jsirois Aug 29, 2018

Member

NB: PUT, GET and DELETE already followed redirects by default - I'm just making this explicit here.

@stuhood
Copy link
Member

stuhood left a comment

Thanks!

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Aug 29, 2018

Thanks for the review Stu.

@jsirois jsirois merged commit 11aa11f into pantsbuild:master Aug 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:issues/6411 branch Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment