New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set JDK properties for remote execution #6417

merged 2 commits into from Aug 30, 2018


None yet
4 participants
Copy link

illicitonion commented Aug 30, 2018

As implemented in twitter/scoot#391 on the

Set JDK properties for remote execution
As implemented in twitter/scoot#391 on the

@illicitonion illicitonion added this to the 1.10.x milestone Aug 30, 2018

@illicitonion illicitonion requested review from ity , blorente and dotordogh Aug 30, 2018

Copy link

blorente left a comment

Super personal style things. Otherwise the code looks good and the tests run. Thanks!


This comment has been minimized.

Copy link

blorente commented Aug 30, 2018

Also, references #6416

Copy link

stuhood left a comment


@illicitonion illicitonion merged commit 0b4b673 into pantsbuild:master Aug 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

@illicitonion illicitonion deleted the twitter:dwagnerhall/process_execution/jdk branch Aug 30, 2018

ity added a commit to ity/pants that referenced this pull request Sep 5, 2018

@ity ity added the needs-cherrypick label Sep 5, 2018

@ity ity removed the needs-cherrypick label Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment