New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable rust clippy on its own shard #6419

Merged
merged 1 commit into from Aug 30, 2018

Conversation

Projects
None yet
2 participants
@illicitonion
Copy link
Contributor

illicitonion commented Aug 30, 2018

Marked allow_failures because it may pick up transient breakages from nightly rust

@illicitonion illicitonion requested review from stuhood and benjyw Aug 30, 2018

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/clippy branch 4 times, most recently from e46b09c to 51d621f Aug 30, 2018

Re-enable rust clippy on its own shard
Marked allow_failures because it may pick up transient breakages from nightly rust

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/clippy branch from 51d621f to fb12b9e Aug 30, 2018

language: python
python: "2.7.13"
before_install:
- sudo apt-get install -y pkg-config fuse libfuse-dev

This comment has been minimized.

@stuhood

stuhood Aug 30, 2018

Member

Hm... does clippy run the tests as well? Doesn't seem like you'd need fuse otherwise.

This comment has been minimized.

@illicitonion

illicitonion Aug 30, 2018

Contributor

Compiling the fuse crate requires libfuse-dev to be installed... I figured might as well include fuse so we can run tests in the future, but happy to remove it if you'd prefer

This comment has been minimized.

@stuhood

stuhood Aug 30, 2018

Member

...oh, libfuse-dev certainly though.

@illicitonion illicitonion merged commit d114810 into pantsbuild:master Aug 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/clippy branch Aug 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment