New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify release docs for stable branches. #6427

Merged
merged 2 commits into from Aug 31, 2018

Conversation

Projects
None yet
3 participants
@stuhood
Copy link
Member

stuhood commented Aug 31, 2018

Problem

The release docs currently indicate that you need to be on the master branch in order to execute a release, which is not the case for stable releases.

Solution

Clarify that you should be on the relevant release branch when releasing.

@cosmicexplorer
Copy link
Contributor

cosmicexplorer left a comment

Thanks!

master, so get on master and ensure your version number commit is present.
After confirming this, run.
like to try one anyway. To do so, switch to your release branch (which will either be `master` for
a unstable weekly release, or a release branch like `1.9.x` for a stable release), and ensure that

This comment has been minimized.

@cosmicexplorer

cosmicexplorer Aug 31, 2018

Contributor

This makes a lot more sense now, and I think making the distinction between weekly and stable is important.

master, so get on master and ensure your version number commit is present.
After confirming this, run.
like to try one anyway. To do so, switch to your release branch (which will either be `master` for
a unstable weekly release, or a release branch like `1.9.x` for a stable release), and ensure that

This comment has been minimized.

@jsirois

jsirois Aug 31, 2018

Member

s/a unstable/an unstable/

@stuhood stuhood merged commit 1797a4f into pantsbuild:master Aug 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/clarify-stable-branch-release-docs branch Aug 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment