Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Stop setting CAS upload deadline #6433
This is currently blocked because grpcio doesn't have an obvious way of erroring out if a remote host can't be DNS resolved.
We can try to hack around this by manually probing or something, or racing all operations with timeouts, or possibly switching to Tower will help us out. I'll investigate some time soon-ish.
Looks like this may be related to grpc/grpc#14170 or similar, but the grpcio version of grpc is pretty old (~1 year), so this is hard to cherry-pick in.
I'm going to punt on this until we switch to Tower, which has an explicit TCP connection future which may fail in a useful way. In the mean time, we can bump the default to be large enough that we'll never hit this error, at the expense of never failing if someone passes a bad DNS address