New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get clippy from the beta channel. #6441

Merged
merged 1 commit into from Sep 3, 2018

Conversation

Projects
None yet
3 participants
@jsirois
Copy link
Member

jsirois commented Sep 2, 2018

It is no longer available on nightly and our CI errors out as a result.

Get clippy from the beta channel.
It is no longer available on nightly and our CI errors out as a result.
@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Sep 2, 2018

If this goes green I'll submit TBR to unbreak PRs.

@jsirois jsirois requested review from illicitonion and stuhood Sep 2, 2018

@jsirois jsirois merged commit 6221f3a into pantsbuild:master Sep 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:clippy/fixup_ci branch Sep 3, 2018

@illicitonion

This comment has been minimized.

Copy link
Contributor

illicitonion commented Sep 3, 2018

Thanks for fixing this up - the change looks good.

What PRs were blocked here? This shard is labelled as ok to fail, and I verified that both PRs and merged commits get green ticks even if this shard is failing...

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Sep 3, 2018

@illicitonion

This comment has been minimized.

Copy link
Contributor

illicitonion commented Sep 3, 2018

Aha, that PR specifically undoes the allowed-to-fail by renaming the clippy shard :) - were it not for that, the matrix explicitly states that the failure was allowed at the bottom, e.g. https://travis-ci.org/pantsbuild/pants/builds/422576002 and colours everything global green (e.g. the tick on #6419 and the favicon on https://travis-ci.org/pantsbuild/pants/builds/422576002)

The reason for allowing failures there is that clippy isn't yet available in stable rust (and was until very recently only available on nightly, not beta) - particularly when on nightly, random breakage in rust may break things. I was planning on marking this not allowed to fail when clippy hit stable (in a few weeks), but beta should be stable enough to block on failures too.

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Sep 3, 2018

@illicitonion

This comment has been minimized.

Copy link
Contributor

illicitonion commented Sep 3, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Sep 4, 2018

Yeah, I've seen other projects have a whole separate table, with a heading "Allowed failures" above it, which made it a lot more clear, but couldn't work out how to make that happen for us :(

I think that that might be a Build Stage. I'm not sure that having it wait until everything has finished would be a great idea though... it certainly wouldn't bias toward keeping it green.

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Sep 4, 2018

Agreed, not nice to head or tail block on a stage. I have a yak queued that explicitly names the shard in a way likely to catch the eye despite an early red x.

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Sep 6, 2018

OK - #6440 has the ui compromise for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment