New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs_util and process_executor: Use default --local-store-path #6444

Merged
merged 1 commit into from Sep 5, 2018

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

illicitonion commented Sep 3, 2018

No description provided.

@illicitonion illicitonion requested review from blorente and dotordogh Sep 3, 2018

@blorente
Copy link
Contributor

blorente left a comment

Love the clean solution!

let store_dir = top_match
.value_of("local-store-path")
.map(PathBuf::from)
.unwrap_or_else(Store::default_path);

This comment has been minimized.

@blorente

blorente Sep 3, 2018

Contributor

Such functional 👍

@stuhood

stuhood approved these changes Sep 4, 2018

Copy link
Member

stuhood left a comment

Thanks!

@illicitonion illicitonion merged commit 8408d28 into pantsbuild:master Sep 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/local-store-path branch Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment