New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pants_requirement environment markers. #6451

Merged
merged 1 commit into from Sep 5, 2018

Conversation

Projects
None yet
2 participants
@jsirois
Copy link
Member

jsirois commented Sep 4, 2018

These need to match our released wheels.

Fixes #6448

@stuhood

stuhood approved these changes Sep 4, 2018

Copy link
Member

stuhood left a comment

Thanks.

@@ -50,7 +50,9 @@ def __call__(self, name=None, dist=None):
msg='The {} target only works for pantsbuild.pants '
'distributions, given {}'.format(self.alias, dist))

env_marker = "python_version>='3.4' or (python_version>='2.7' and python_version<'3')"
# Update the environment marker in lockstep with other changes as described in

This comment has been minimized.

@stuhood

stuhood Sep 4, 2018

Member

Is it worth having these comments refer to one another by suggesting looking for other instances of https://github.com/pantsbuild/pants/issues/6450 in the codebase?

This comment has been minimized.

@jsirois

jsirois Sep 4, 2018

Member

I don't think so - the comments already fan into the issue which has pointers to the three code locations.

@jsirois jsirois force-pushed the jsirois:issues/6448 branch from c2037bf to 07c5807 Sep 4, 2018

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Sep 4, 2018

Rebased to pick up the CI fix in #6452 and #6454 . I'll submit if CI goes green.

Fix pants_requirement environment markers.
These need to match our released wheels.

Fixes #6448

@jsirois jsirois force-pushed the jsirois:issues/6448 branch from 07c5807 to c3583cc Sep 5, 2018

@jsirois jsirois merged commit 5151a77 into pantsbuild:master Sep 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:issues/6448 branch Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment