New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around production `coverage` float. #6452

Merged
merged 1 commit into from Sep 4, 2018

Conversation

Projects
None yet
2 participants
@jsirois
Copy link
Member

jsirois commented Sep 4, 2018

Ensure the hard dependency on coverage in tests matches the otherwise
floating indirect dependency on coverage via pytest-cov in
production code.

Work around production `coverage` float.
Ensure the hard dependency on `coverage` in tests matches the otherwise
floating indirect dependency on `coverage` via `pytest-cov` in
production code.
@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Sep 4, 2018

Failures were 100% reproducible and looked like:

E           CoverageException: Couldn't read data from '/tmp/tmpZxg30I_BUILD_ROOT/.coverage': CoverageException: Doesn't seem to be a coverage.py data file

These are now fixed.

@stuhood

stuhood approved these changes Sep 4, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Sep 4, 2018

There was a hang in pantsd in travis (hopefully due to #6426). Restarted that shard.

@stuhood stuhood merged commit 81af00b into pantsbuild:master Sep 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood added this to the 1.9.x milestone Sep 7, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Sep 7, 2018

It looks like the 1.9.x branch is experiencing the float as well. Going to cherry pick this there. cc @cosmicexplorer

stuhood added a commit that referenced this pull request Sep 7, 2018

Work around production `coverage` float. (#6452)
Ensure the hard dependency on `coverage` in tests matches the otherwise
floating indirect dependency on `coverage` via `pytest-cov` in
production code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment