Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[fix] Pass full path to isdir rather than just basename. #6453
(Waiting for tests to pass)
While debugging an issue with a build, I stumbled on this (unrelated) bug within pants. When we look for cached interpreters, we iterate through the files in
Pass in joined path to
This should not affect end user.
Thanks! Would you be able to add a test that covers this? Maybe in https://github.com/pantsbuild/pants/blob/232513b6b9bd2b56ce60193018e55bce399ed899/tests/python/pants_test/backend/python/test_interpreter_cache.py
Added some tests for this fix. For info, this is what test output is for master:
Pants is not picking up our cached interpreter.