New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup `JsonEncoderTest` encoding tests. #6457

Merged
merged 1 commit into from Sep 5, 2018

Conversation

Projects
None yet
3 participants
@jsirois
Copy link
Member

jsirois commented Sep 5, 2018

Previously a complex workaround existed to handle arbitrary key ordering
under different pythons. Simplify and just ask json to order keys for
the tests.

Fixes #6456

@jsirois jsirois requested a review from cosmicexplorer Sep 5, 2018

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Sep 5, 2018

/cc @Eric-Arellano

This essentially reverts Eric's fix in #6133 and Danny's fix of the fix in #6454 in favor of a simpler and I think clearer fix to the original tests.

Fixup `JsonEncoderTest` encoding tests.
Previously a complex workaround existed to handle arbitrary key ordering
under different pythons. Simplify and just ask json to order keys for
the tests.

Fixes #6456

@jsirois jsirois force-pushed the jsirois:issues/6456 branch from 4d35247 to 7d53d37 Sep 5, 2018

@stuhood

stuhood approved these changes Sep 5, 2018

Copy link
Member

stuhood left a comment

Thanks!

@Eric-Arellano
Copy link
Contributor

Eric-Arellano left a comment

This is so much better. Thanks John!

@jsirois jsirois merged commit 4d79e1f into pantsbuild:master Sep 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:issues/6456 branch Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment