New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure unstable pants dists can never conflict. #6460

Merged
merged 1 commit into from Sep 6, 2018

Conversation

Projects
None yet
1 participant
@jsirois
Copy link
Member

jsirois commented Sep 6, 2018

This pushes the version of unstable pants dists we generate for tests
to one older than any released pants avoiding contamination of caches
with otherwise valid-looking prereleases.

Fixes #6459.

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Sep 6, 2018

NB: This fix only works with a clearing of Travis caches, which I'll do presently.

@jsirois jsirois requested a review from cosmicexplorer Sep 6, 2018

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Sep 6, 2018

If this goes green I'll submit TBR to unbreak PR CIs.

Ensure unstable pants dists can never conflict.
This pushes the version of unstable pants dists we generate for tests
to one older than any released pants avoiding contamination of caches
with otherwise valid-looking prereleases.

Fixes #6459.

@jsirois jsirois force-pushed the jsirois:issues/6459 branch from 7fc6aeb to e7d4e5d Sep 6, 2018

@jsirois jsirois merged commit 5697ee6 into pantsbuild:master Sep 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:issues/6459 branch Sep 6, 2018

jsirois added a commit to jsirois/pants that referenced this pull request Sep 6, 2018

Re-enable pants_setup_requires:bin IT.
The reason this target had resolution failures was fixed in pantsbuild#6460.

This is a partial fix for pantsbuild#6455.

jsirois added a commit to jsirois/pants that referenced this pull request Sep 7, 2018

Re-enable pants_setup_requires:bin IT.
The reason this target had resolution failures was fixed in pantsbuild#6460.

This is a partial fix for pantsbuild#6455.

jsirois added a commit that referenced this pull request Sep 8, 2018

Re-enable pants_setup_requires:bin IT. (#6466)
The reason this target had resolution failures was fixed in #6460.

This is a partial fix for #6455.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment