New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend fs_util deadline to 30 minutes #6471

Merged
merged 2 commits into from Sep 10, 2018

Conversation

Projects
3 participants
@illicitonion
Copy link
Contributor

illicitonion commented Sep 7, 2018

This deadline is really only in place because otherwise DNS failures
leave this hanging forever.

Make fs_util have a very long deadline (because it's not configurable,
like it is inside pants) until we switch to Tower (where we can more
carefully control specific components of timeouts).

See #6433 for more context.

@illicitonion illicitonion requested a review from stuhood Sep 7, 2018

@illicitonion illicitonion added this to To do in Remoting via automation Sep 7, 2018

@illicitonion illicitonion requested a review from dgassaway Sep 7, 2018

@dgassaway
Copy link

dgassaway left a comment

LGTM

@stuhood

stuhood approved these changes Sep 7, 2018

@@ -216,7 +216,7 @@ fn execute(top_match: &clap::ArgMatches) -> Result<(), ExitError> {
cas_address.to_owned(),
1,
chunk_size,
Duration::from_secs(30),
Duration::from_secs(30 * 60),

This comment has been minimized.

@stuhood

stuhood Sep 7, 2018

Member

All of the PR description probably could have gone here in a comment instead. For next time!

illicitonion added some commits Sep 7, 2018

Extend fs_util deadline to 30 minutes
This deadline is really only in place because otherwise DNS failures
leave this hanging forever.

Make fs_util have a very long deadline (because it's not configurable,
like it is inside pants) until we switch to Tower (where we can more
carefully control specific components of timeouts).

See #6433 for more context.

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/fsutil/extend branch from 9105cde to be960b3 Sep 10, 2018

@illicitonion illicitonion merged commit 222e0e7 into pantsbuild:master Sep 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Remoting automation moved this from To do to Done Sep 10, 2018

@illicitonion illicitonion deleted the twitter:dwagnerhall/fsutil/extend branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment