New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make fatal_warnings_enabled_args a tuple in javac compile instead of just parens #6497

Merged
merged 1 commit into from Sep 13, 2018

Conversation

Projects
None yet
4 participants
@cosmicexplorer
Copy link
Contributor

cosmicexplorer commented Sep 12, 2018

Problem

> ./pants options | grep compile.javac.fatal_warnings_enabled_args
compile.javac.fatal_warnings_enabled_args =  [u'-', u'W', u'e', u'r', u'r', u'o', u'r'] (from HARDCODED)

Solution

  • Add a comma to make a tuple instead of a string in the javac compile task.

Result

The default value is a list of strings, not a string split into single characters and wrapped into a list.

@cosmicexplorer cosmicexplorer requested review from illicitonion and cheister Sep 12, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Sep 12, 2018

Oy. Thanks.

@cosmicexplorer cosmicexplorer merged commit 731d5f8 into pantsbuild:master Sep 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment