New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass through `compatibility` to synthetic python thrift targets #6499

Merged
merged 3 commits into from Sep 13, 2018

Conversation

Projects
None yet
4 participants
@cosmicexplorer
Copy link
Contributor

cosmicexplorer commented Sep 12, 2018

Problem

Resolves #6484.

Solution

  • Add compatibility to the override of _copy_target_attributes() for ApacheThriftPyGen.
  • Add a test to ensure the synthetic python targets have the precise compatibility attribute copied from the thrift target.

cosmicexplorer added some commits Sep 12, 2018

@cosmicexplorer cosmicexplorer requested review from jsirois , benjyw and ity Sep 12, 2018

python_setup = global_subsystem_instance(PythonSetup)
interpreter_cache = PythonInterpreterCache(python_setup, python_repos)

interpreter = interpreter_cache.select_interpreter_for_targets([py2_synthetic_target])

This comment has been minimized.

@jsirois

jsirois Sep 12, 2018

Member

Why not just:

self.assertEqual(py2_thrift_library.compatibility, py2_synthetic_target.compatibility)

It tests what you want directly and is much lighter weight.

This comment has been minimized.

@cosmicexplorer

cosmicexplorer Sep 12, 2018

Contributor

There's indeed no reason to do the whole interpreter selection process, and I have implemented this in 973994c.

@ity

ity approved these changes Sep 12, 2018

Copy link
Member

ity left a comment

looks great - thank you!

@cosmicexplorer cosmicexplorer merged commit 43b8841 into pantsbuild:master Sep 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment