Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
create singleton ExceptionSink object to centralize logging of fatal errors #6533
See #6530. We want to make it simpler to understand where logging of fatal errors occurs and to consume those logs in a structured way.
We now have an object that can be used to centralize the logging of fatal errors and enables the creation of a single point of failure (by which I mean, a single area of code which describes where this process's exceptions are logged and how to access and append to them), to be implemented in followup PRs.
referenced this pull request
Sep 19, 2018
def _log_exception(self, msg): if self._workdir: ExceptionSink.instance.set_destination(self._workdir) ExceptionSink.instance.log_exception(msg)