Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
first attempt at centralizing more global error logging state in ExceptionSink #6552
See #6530. This is bullet point 2 of that issue.
Thanks... I think the biggest blocker to getting that test passing will be the fact that the signal handler will not currently write to the exception log. Doing that will require a bit of refactoring.
3 times, most recently
Sep 30, 2018
Thanks, this looks good. It would be great to continue to (lightly) refine the relationship between the Exiter and the ExceptionSink to make their individual responsibilities clearer... but it looks logically correct from my end.