New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExecuteProcessRequest works with overlapping output files and dirs #6559

Merged
merged 2 commits into from Sep 27, 2018

Conversation

Projects
None yet
5 participants
@illicitonion
Copy link
Contributor

illicitonion commented Sep 26, 2018

Fixes #6558

@illicitonion illicitonion requested review from ity , blorente and dotordogh Sep 26, 2018

@blorente
Copy link
Contributor

blorente left a comment

Thanks!

@stuhood
Copy link
Member

stuhood left a comment

This works, but would be good to look again at just using globs.

.collect();
// Sort both for consistent results and to allow deduping.

This comment has been minimized.

@stuhood

stuhood Sep 26, 2018

Member

I think that we would get this for free if we used globs to capture these, similar to how we capture directories. And we could probably do it with one invoke.

I can't remember why we did this as "use globs for dirs" and "use literals for literals", but doing it all with globs might be easier.

This comment has been minimized.

@illicitonion

illicitonion Sep 27, 2018

Contributor

Done :)

@ity

ity approved these changes Sep 26, 2018

@illicitonion illicitonion merged commit 273b065 into pantsbuild:master Sep 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/duplicatestats branch Sep 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment