New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rules-graph] ensure params in messages are sorted alphabetically #6562

Merged
merged 1 commit into from Sep 26, 2018

Conversation

Projects
None yet
2 participants
@baroquebobcat
Copy link
Contributor

baroquebobcat commented Sep 26, 2018

Problem

There's a test that depends on param ordering in these messages, but the ordering isn't deterministic run over run

Solution

Sort the param type names when constructing diagnostic messages.

[rules-graph] ensure params in messages are sorted alphabetically
# Problem

There's a test that depends on param ordering in these messages, but the ordering isn't deterministic run over run

# Solution

Sort the param type names when constructing diagnostic messages
@stuhood
Copy link
Member

stuhood left a comment

Thanks!

@baroquebobcat baroquebobcat merged commit 6268a77 into pantsbuild:master Sep 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment