New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zinc-compile][hermetic] raise failure on compile failures #6563

Merged
merged 2 commits into from Sep 27, 2018

Conversation

Projects
None yet
2 participants
@baroquebobcat
Copy link
Contributor

baroquebobcat commented Sep 27, 2018

Problem

Zinc compiler failures do not cause the rest of the compile to fail because they are not propagated.

Solution

Raise an exception on failure.

Result

Instead of caching failed zinc compiles, pants will run them again on a subsequent invoke.

[zinc-compile][hermetic] raise failure on compil failures
### Problem

Zinc compiler failures do not cause the rest of the compile to fail because they are not propagated.

### Solution

Raise an exception on failure.

### Result

Instead of caching failed zinc compiles, pants will run them again on a subsequent invoke.
@@ -438,6 +438,9 @@ def relative_to_exec_root(path):
jdk_home=text_type(self._zinc.underlying_dist.home),
)
res = self.context.execute_process_synchronously_without_raising(req, self.name(), [WorkUnitLabel.COMPILER])

This comment has been minimized.

@stuhood

stuhood Sep 27, 2018

Member

Should this switch to execute_process_synchronously ?

This comment has been minimized.

@baroquebobcat

baroquebobcat Sep 27, 2018

Contributor

That'd probably work too.

This comment has been minimized.

@baroquebobcat

baroquebobcat Sep 27, 2018

Contributor

Trying it out

This comment has been minimized.

@baroquebobcat

baroquebobcat Sep 27, 2018

Contributor

Works. Updated.

@baroquebobcat baroquebobcat changed the title [zinc-compile][hermetic] raise failure on compil failures [zinc-compile][hermetic] raise failure on compile failures Sep 27, 2018

@baroquebobcat baroquebobcat merged commit 0d4cd70 into pantsbuild:master Sep 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment