New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forbidden imports check to ban std::sync primitives. #6566

Merged
merged 1 commit into from Sep 28, 2018

Conversation

Projects
None yet
2 participants
@stuhood
Copy link
Member

stuhood commented Sep 27, 2018

Problem

#6564 replaces usage of std::sync primitives, but doesn't ban them.

Solution

Ban them as well.

@stuhood stuhood requested a review from illicitonion Sep 27, 2018

@illicitonion
Copy link
Contributor

illicitonion left a comment

Thanks!

@stuhood stuhood merged commit 113a987 into pantsbuild:master Sep 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/forbidden-imports-check-for-std-sync branch Sep 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment