New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin jupyter transitive deps in integration tests #6568

Merged
merged 2 commits into from Sep 28, 2018

Conversation

Projects
None yet
2 participants
@stuhood
Copy link
Member

stuhood commented Sep 27, 2018

Problem

As described in pantsbuild/pex#561, jupyter's transitive deps float. Today that caused breakage.

Solution

Pin the relevant deps (ht John in pantsbuild/pex#562).

@stuhood stuhood requested review from jsirois , kwlzn and CMLivingston Sep 27, 2018

@stuhood stuhood modified the milestones: 1.9.x, 1.10.x Sep 27, 2018

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Sep 27, 2018

This does not seem to jive with the depending target above which has a python 3 compatibility constraint.

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Sep 27, 2018

Mm. I tested that it fixed the broken test, but didn't go much further. Now running the whole suite locally.

@jsirois
Copy link
Member

jsirois left a comment

Thanks in advance for squaring this comment with the one above.

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Sep 28, 2018

Will merge on green for the first commit.

@stuhood stuhood merged commit 56cb981 into pantsbuild:master Sep 28, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@stuhood stuhood deleted the twitter:stuhood/pin-jupyter-transitive-deps branch Sep 28, 2018

stuhood added a commit that referenced this pull request Sep 28, 2018

Pin jupyter transitive deps in integration tests (#6568)
### Problem

As described in pantsbuild/pex#561, jupyter's transitive deps float. Today that caused breakage.

### Solution

Pin the relevant deps (ht John in pantsbuild/pex#562).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment