New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow instance name to be set for remote executions #6580

Merged
merged 1 commit into from Oct 3, 2018

Conversation

Projects
None yet
2 participants
@illicitonion
Copy link
Contributor

illicitonion commented Oct 2, 2018

As per the spec in the proto.

@illicitonion illicitonion requested review from ity , blorente and dotordogh Oct 2, 2018

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/remoting/instance_name branch from b8dd58b to 09daa65 Oct 2, 2018

@illicitonion

This comment has been minimized.

Copy link
Contributor

illicitonion commented Oct 2, 2018

Depends on #6582

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/remoting/instance_name branch from 09daa65 to a744f02 Oct 2, 2018

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/remoting/instance_name branch from a744f02 to 0c83513 Oct 2, 2018

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/remoting/instance_name branch from 0c83513 to 9e00419 Oct 2, 2018

@ity

ity approved these changes Oct 3, 2018

@@ -2834,6 +2855,71 @@ mod tests {
);
}

#[test]

This comment has been minimized.

@ity

ity Oct 3, 2018

Member

thank you for adding tests!

@illicitonion illicitonion merged commit 3e629b8 into pantsbuild:master Oct 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/remoting/instance_name branch Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment